add node-problem-detector-compat#3398
Merged
rawlingsj merged 1 commit intowolfi-dev:mainfrom Jul 6, 2023
Merged
Conversation
developer-guy
force-pushed
the
feature/add-compat-npd
branch
from
ec65c8b to
daff77a
Compare
rawlingsj
previously approved these changes
Jul 6, 2023
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev> Co-authored-by: Furkan Turkal <furkan.turkal@chainguard.dev> Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
developer-guy
force-pushed
the
feature/add-compat-npd
branch
from
daff77a to
f6b2097
Compare
rawlingsj
approved these changes
Jul 6, 2023
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Since we put the
node-problem-detectorbinary under /usr/bin/ by default, official image puts it under root / path. So we have to adjust the command to make it work.Related: github.com/chainguard-images/images/pull/870
Pre-review Checklist
For new package PRs only
packages.txtFor security-related PRs
advisoriesandsecfixesFor version bump PRs
epochfield is reset to 0